Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: overhaul ci and cd workflows #326

Merged
merged 23 commits into from
Jul 17, 2024
Merged

Conversation

afuetterer
Copy link
Contributor

Fixes #325

.github/workflows/cd.yml Outdated Show resolved Hide resolved
.github/workflows/cd.yml Outdated Show resolved Hide resolved
.github/workflows/cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.95%. Comparing base (1ea4032) to head (c6564a8).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #326      +/-   ##
==========================================
+ Coverage   84.93%   85.95%   +1.02%     
==========================================
  Files          17       17              
  Lines        4202     4202              
  Branches      988      988              
==========================================
+ Hits         3569     3612      +43     
+ Misses        474      431      -43     
  Partials      159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkstrp
Copy link
Member

lkstrp commented Jul 10, 2024

If you don't mind, I would just add some changes

@afuetterer
Copy link
Contributor Author

If you don't mind, I would just add some changes

Of course, go ahead.

@afuetterer
Copy link
Contributor Author

Plesse see the output of baipp:

https://github.com/PyPSA/linopy/actions/runs/9871896061/attempts/1#summary-27260815050

I think this is really helpful.

@lkstrp
Copy link
Member

lkstrp commented Jul 10, 2024

@afuetterer
This is all super great. Thanks a lot for your input !
I made some smaller adjustments and added trusted publishing and tried to use the baipp dist also for tests. Would you have a look?

CI with the baipp versions still needs a fix.

@afuetterer

This comment was marked as outdated.

@afuetterer
Copy link
Contributor Author

I added concurrency to cancel early, if multiple commits are pushed in short time to the same PR.

@afuetterer
Copy link
Contributor Author

Okay, well, of course you needed to have python versions defined in the pyproject.toml. 😄

@afuetterer
Copy link
Contributor Author

Oh my god, finally. Please squash. 😄

@afuetterer
Copy link
Contributor Author

Should I squash the commits or do you perform squash and merge?

Any more changes at the moment?

@afuetterer
Copy link
Contributor Author

I guess you need to update the required check in your PR settings. It hangs.

@afuetterer

This comment was marked as resolved.

Copy link
Member

@lkstrp lkstrp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let @FabianHofmann squash and merge.

Thanks a lot for all your input @afuetterer !

.github/workflows/cd.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@afuetterer
Copy link
Contributor Author

Fingers crossed, that the release workflow and the trusted publishing works.

@lkstrp
Copy link
Member

lkstrp commented Jul 11, 2024

Fingers crossed, that the release workflow and the trusted publishing works.

I will test that in a release of a different repo soon

@FabianHofmann
Copy link
Collaborator

@lkstrp let me know if we should merge this

@lkstrp
Copy link
Member

lkstrp commented Jul 17, 2024

@FabianHofmann Let's go

@FabianHofmann FabianHofmann merged commit b1a52dc into PyPSA:master Jul 17, 2024
16 checks passed
@afuetterer afuetterer deleted the 325-ci-cd branch July 17, 2024 10:49
@afuetterer
Copy link
Contributor Author

Oh no.
You did not squash the commits, instead you merged my messy 20+ testing commits.

@FabianHofmann
Copy link
Collaborator

ah damn forgot about that, a good reminder that we wanted to set squash as default for prs

@afuetterer
Copy link
Contributor Author

Good idea.
Now you have my, try, try, finally commit messages in your history. :)

@FabianHofmann
Copy link
Collaborator

so that everybody these sees that effort you have made ;) thanks for the nice contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overhaul CI and CD workflows
3 participants